[lkml]   [2009]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] kernel.h: Add a never optimized away pr_dbg for printk(KERN_DEBUG pr_fmt(fmt)...)
    On Tue, 2009-10-13 at 20:34 -0700, David Rientjes wrote:
    > On Tue, 13 Oct 2009, Joe Perches wrote:
    > > Many developers use a logging message that
    > > is printed at KERN_DEBUG level that is always
    > > printed regardless of #define DEBUG levels.
    > > pr_debug can be optimized away to a null statement.
    > > Add a pr_dbg message that prints at KERN_DEBUG
    > > level that uses pr_fmt() that can not be optimized
    > > to nothing.
    > pr_dbg() is horribly misnamed, it doesn't indicate why it exists vs.
    > pr_debug() at all.

    Partially true, it's reasonably named because it's very short.

    > Future users will undoubtedly use it by mistake when
    > they only really mean for the message to be emitted on DEBUG because
    > they've seen it in other places and haven't checked the implementation.

    The cost of using pr_dbg instead of pr_debug isn't high.

    The primary benefit is getting an automatic pr_fmt
    and shorter code.

    > I'd suggest pr_debug_force(), even though it's much longer (although still
    > shorter than printk(KERN_DEBUG)).

    pr_dbg allows longer format strings without exceeding 80 chars.


    Other suggestions?

     \ /
      Last update: 2009-10-14 06:25    [W:0.021 / U:20.960 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site