lkml.org 
[lkml]   [2009]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:bkl/drivers] drivers: Remove BKL from pc8736x_gpio
    Commit-ID:  71d69bc2c0202f438669073d849999d2f6b6ca31
    Gitweb: http://git.kernel.org/tip/71d69bc2c0202f438669073d849999d2f6b6ca31
    Author: Thomas Gleixner <tglx@linutronix.de>
    AuthorDate: Sat, 10 Oct 2009 15:56:00 +0200
    Committer: Thomas Gleixner <tglx@linutronix.de>
    CommitDate: Wed, 14 Oct 2009 17:36:52 +0200

    drivers: Remove BKL from pc8736x_gpio

    cycle_kernel_lock() was added during the big BKL pushdown. It should
    ensure the serializiation against driver init code. In this case there
    is nothing to serialize. Remove it.

    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    LKML-Reference: <20091010153350.127093710@linutronix.de>
    Acked-by: Jim Cromie <jim.cromie@gmail.com>
    ---
    drivers/char/pc8736x_gpio.c | 2 --
    1 files changed, 0 insertions(+), 2 deletions(-)

    diff --git a/drivers/char/pc8736x_gpio.c b/drivers/char/pc8736x_gpio.c
    index 3f7da8c..8ecbcc1 100644
    --- a/drivers/char/pc8736x_gpio.c
    +++ b/drivers/char/pc8736x_gpio.c
    @@ -20,7 +20,6 @@
    #include <linux/mutex.h>
    #include <linux/nsc_gpio.h>
    #include <linux/platform_device.h>
    -#include <linux/smp_lock.h>
    #include <asm/uaccess.h>

    #define DEVNAME "pc8736x_gpio"
    @@ -223,7 +222,6 @@ static int pc8736x_gpio_open(struct inode *inode, struct file *file)
    unsigned m = iminor(inode);
    file->private_data = &pc8736x_gpio_ops;

    - cycle_kernel_lock();
    dev_dbg(&pdev->dev, "open %d\n", m);

    if (m >= PC8736X_GPIO_CT)

    \
     
     \ /
      Last update: 2009-10-14 18:15    [W:0.024 / U:0.188 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site