lkml.org 
[lkml]   [2009]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:bkl/drivers] spi: Remove BKL from spidev_open
    Commit-ID:  4c2aedc2543248c3fdc8c06c662b589d36c93bbb
    Gitweb: http://git.kernel.org/tip/4c2aedc2543248c3fdc8c06c662b589d36c93bbb
    Author: Thomas Gleixner <tglx@linutronix.de>
    AuthorDate: Sat, 10 Oct 2009 15:35:52 +0000
    Committer: Thomas Gleixner <tglx@linutronix.de>
    CommitDate: Wed, 14 Oct 2009 17:36:48 +0200

    spi: Remove BKL from spidev_open

    The BKL was added there with the big pushdown. Remove it as the code
    is serialized already.

    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    LKML-Reference: <20091010153349.318535932@linutronix.de>
    Cc: David Brownell <dbrownell@users.sourceforge.net>
    ---
    drivers/spi/spidev.c | 3 ---
    1 files changed, 0 insertions(+), 3 deletions(-)

    diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
    index 5d23983..815a650 100644
    --- a/drivers/spi/spidev.c
    +++ b/drivers/spi/spidev.c
    @@ -30,7 +30,6 @@
    #include <linux/errno.h>
    #include <linux/mutex.h>
    #include <linux/slab.h>
    -#include <linux/smp_lock.h>

    #include <linux/spi/spi.h>
    #include <linux/spi/spidev.h>
    @@ -477,7 +476,6 @@ static int spidev_open(struct inode *inode, struct file *filp)
    struct spidev_data *spidev;
    int status = -ENXIO;

    - lock_kernel();
    mutex_lock(&device_list_lock);

    list_for_each_entry(spidev, &device_list, device_entry) {
    @@ -503,7 +501,6 @@ static int spidev_open(struct inode *inode, struct file *filp)
    pr_debug("spidev: nothing for minor %d\n", iminor(inode));

    mutex_unlock(&device_list_lock);
    - unlock_kernel();
    return status;
    }


    \
     
     \ /
      Last update: 2009-10-14 18:15    [W:4.210 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site