lkml.org 
[lkml]   [2009]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:bkl/drivers] drivers: Remove BKL from scx200_gpio
    Commit-ID:  3a8183a2061ba54c4c2b3cd31c3add6fd717e853
    Gitweb: http://git.kernel.org/tip/3a8183a2061ba54c4c2b3cd31c3add6fd717e853
    Author: Thomas Gleixner <tglx@linutronix.de>
    AuthorDate: Sat, 10 Oct 2009 16:02:53 +0200
    Committer: Thomas Gleixner <tglx@linutronix.de>
    CommitDate: Wed, 14 Oct 2009 17:36:53 +0200

    drivers: Remove BKL from scx200_gpio

    cycle_kernel_lock() was added during the big BKL pushdown. It should
    ensure the serializiation against driver init code. In this case there
    is nothing to serialize. Remove it.

    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    LKML-Reference: <20091010153350.167321547@linutronix.de>
    Acked-by: Jim Cromie <jim.cromie@gmail.com>
    ---
    drivers/char/scx200_gpio.c | 2 --
    1 files changed, 0 insertions(+), 2 deletions(-)

    diff --git a/drivers/char/scx200_gpio.c b/drivers/char/scx200_gpio.c
    index 1d91005..99e5272 100644
    --- a/drivers/char/scx200_gpio.c
    +++ b/drivers/char/scx200_gpio.c
    @@ -12,7 +12,6 @@
    #include <linux/kernel.h>
    #include <linux/init.h>
    #include <linux/platform_device.h>
    -#include <linux/smp_lock.h>
    #include <asm/uaccess.h>
    #include <asm/io.h>

    @@ -52,7 +51,6 @@ static int scx200_gpio_open(struct inode *inode, struct file *file)
    unsigned m = iminor(inode);
    file->private_data = &scx200_gpio_ops;

    - cycle_kernel_lock();
    if (m >= MAX_PINS)
    return -EINVAL;
    return nonseekable_open(inode, file);

    \
     
     \ /
      Last update: 2009-10-14 18:15    [W:0.024 / U:59.920 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site