lkml.org 
[lkml]   [2009]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:bkl/drivers] inifiband: Remove BKL from ipath_open()
    Commit-ID:  f96d3015e9f7f7fff4cab7ed1d467664cc980061
    Gitweb: http://git.kernel.org/tip/f96d3015e9f7f7fff4cab7ed1d467664cc980061
    Author: Thomas Gleixner <tglx@linutronix.de>
    AuthorDate: Wed, 14 Oct 2009 16:36:26 +0200
    Committer: Thomas Gleixner <tglx@linutronix.de>
    CommitDate: Wed, 14 Oct 2009 17:36:54 +0200

    inifiband: Remove BKL from ipath_open()

    cycle_kernel_lock() got pushed down to ipath_open(). I tried hard to
    understand what it might protect, but finally gave up.

    Roland noted that qlogic seems to have abandoned the ipath driver and
    came to the following wise conclusion: "So I guess if the BKL stuff is
    blocking you in any way, we can just drop it from ipath and leave it
    as yet another race condition in a rotting old driver."

    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    LKML-Reference: <adad44tj090.fsf@cisco.com>
    Cc: Roland Dreier <rdreier@cisco.com>
    ---
    drivers/infiniband/hw/ipath/ipath_file_ops.c | 1 -
    1 files changed, 0 insertions(+), 1 deletions(-)

    diff --git a/drivers/infiniband/hw/ipath/ipath_file_ops.c b/drivers/infiniband/hw/ipath/ipath_file_ops.c
    index 40dbe54..73933a4 100644
    --- a/drivers/infiniband/hw/ipath/ipath_file_ops.c
    +++ b/drivers/infiniband/hw/ipath/ipath_file_ops.c
    @@ -1821,7 +1821,6 @@ done:
    static int ipath_open(struct inode *in, struct file *fp)
    {
    /* The real work is performed later in ipath_assign_port() */
    - cycle_kernel_lock();
    fp->private_data = kzalloc(sizeof(struct ipath_filedata), GFP_KERNEL);
    return fp->private_data ? 0 : -ENOMEM;
    }

    \
     
     \ /
      Last update: 2009-10-14 18:15    [W:0.025 / U:0.720 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site