lkml.org 
[lkml]   [2009]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Bug #14388] keyboard under X with 2.6.31


On Tue, 13 Oct 2009, Linus Torvalds wrote:
>
> Anyway, I'm not entirely happy with this patch, and I haven't actually
> TESTED it so it might well be totally broken [..]

It is.

Looking over the patch a bit more, at a minimum that

if (test_and_set_bit(TTY_FLUSHING, &tty->flags)) {
line should be

if (!test_and_set_bit(TTY_FLUSHING, &tty->flags)) {
(ie add the '!') since we want to do things if the bit wasn't set before
(and if it was already set it all turns into a no-op).

But apart from that obvious typo, the patch still looks good even after
looking it through a bit more. It's still TOTALLY UNTESTED, though!

Linus


\
 
 \ /
  Last update: 2009-10-18 23:28    [W:0.170 / U:0.492 seconds]
©2003-2014 Jasper Spaans. Advertise on this site