lkml.org 
[lkml]   [2009]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH/RFC v5 4/5]: core: Add dump device to call on oopses and panics


    On Tue, 13 Oct 2009, Simon Kagstrom wrote:
    > +
    > +struct dump_device {

    I know I used that name myself in the example code I sent out, but
    thinking about it more, I hate the name.

    Most people think a "dump" is something much more than just the kernel
    messages, so "dump_device" ends up being misleading. And the "device" part
    is kind of pointless and redundant (it need not be a real device).

    So I suspect it would be better to name it by what it does, and make it
    clear what that is.

    Maybe something like "struct kmsg_dumper" or similar. That is pretty
    unambiguous, and nobody is going to get confused about what the semantics
    are.

    > + void (*oops)(struct dump_device *, const char *, unsigned long,
    > + const char *, unsigned long);
    > + void (*panic)(struct dump_device *, const char *, unsigned long,
    > + const char *, unsigned long);

    I don't much like this. Why separate 'oops' and 'panic' functions,
    especially since we migth have many more causes to do a kmsg dump in the
    future (ie 'shutdown', 'sysrq', 'suspend' etc etc)?

    So separating them out as two different functions is just wrong. Make it
    one function, and then perhaps you can add a

    enum kmsg_dump_reason {
    kmsg_dump_panic,
    kmsg_dump_oops,
    ..
    };

    and pass it as an argument.

    > + int (*setup)(struct dump_device *);

    Why?

    There seems to be no reason for this. Who ever registers the dumper should
    just do the setup call itself. Why would we have a callback that just gets
    called immediately, rather than have the registration code just do the
    call itself?

    > +int register_dumpdevice(struct dump_device *dump, void *priv)
    > +{
    > + /* We need at least one of these set */
    > + if (!dump->oops && !dump->panic)
    > + return -EINVAL;
    > + if (dump->setup && dump->setup(dump) != 0)
    > + return -EINVAL;

    So the above two tests should be pointless.

    > + dump->priv = priv;
    > +
    > + INIT_LIST_HEAD(&dump->list);

    Don't do "INIT_LIST_HEAD()" here. It's pointless as far as I can tell (the
    list_add() will initialize it), but even in general we should basically
    have basic initialization done by callers if needed.

    And judging by historical problems in areas like that, we should protect
    against people registering the same dumper twice. One way to do that would
    be to perhaps _require_ that the caller has initialized it, and then do a

    if (!list_empty(&dump->list))
    return -EBUSY;

    (but I could also see using just a "registered" flag)

    > + write_lock(&dump_list_lock);

    This looks dubious. Dumping can obviously happen from interrupts, so _if_
    you were to protect against dumpers, you'd need to use an interrupt-safe
    lock.

    Of course, you do not actually take the lock at dump time (which may be
    intentional, and that is not necessarily wrong - taking locks at oops time
    is generally not a good thing to do, and it may be entirely reasonable to
    say "we take the risk of not locking properly in order to _maybe_ work
    even if the lock is scrogged").

    But if you don't take the lock at dump time (or, perhaps preferably, if
    you make the dump-time lock be a "try_lock()" - maybe the oops is due to
    dump list corruption, and if the dump_list_lock is held thew oopser
    should simply not dump!), then you should probably use a spinlock rather
    than an rwlock.

    > + list_for_each_entry(dump, &dump_list, list) {
    > + if (panic && dump->panic)
    > + dump->panic(dump, s1, l1, s2, l2);
    > + else if (!panic && dump->oops)
    > + dump->oops(dump, s1, l1, s2, l2);
    > + }

    So this would just become

    list_for_each_entry(dump, &dump_list, list)
    dump->fn(dump, s1, l1, s2, l2, reason);

    or something.

    Linus


    \
     
     \ /
      Last update: 2009-10-18 23:28    [W:0.041 / U:93.588 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site