| Subject | Re: [patch 13/28] s390: Remove BKL from prng | From | Jan Glauber <> | Date | Tue, 13 Oct 2009 12:36:14 +0000 |
| |
On Sat, 2009-10-10 at 15:36 +0000, Thomas Gleixner wrote: > einfaches Textdokument attachment (s390-remove-bkl-from-prng.patch) > cycle_kernel_lock() was added during the big BKL pushdown. It should > ensure the serializiation against driver init code. In this case there > is nothing to serialize. Remove it.
Looks good. Acked-by: Jan Glauber <jang.linux.vnet.ibm.com>
-- Jan
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> > --- > arch/s390/crypto/prng.c | 2 -- > 1 file changed, 2 deletions(-) > > Index: linux-2.6-tip/arch/s390/crypto/prng.c > =================================================================== > --- linux-2.6-tip.orig/arch/s390/crypto/prng.c > +++ linux-2.6-tip/arch/s390/crypto/prng.c > @@ -6,7 +6,6 @@ > #include <linux/fs.h> > #include <linux/init.h> > #include <linux/kernel.h> > -#include <linux/smp_lock.h> > #include <linux/miscdevice.h> > #include <linux/module.h> > #include <linux/moduleparam.h> > @@ -49,7 +48,6 @@ static unsigned char parm_block[32] = { > > static int prng_open(struct inode *inode, struct file *file) > { > - cycle_kernel_lock(); > return nonseekable_open(inode, file); > } > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
|