lkml.org 
[lkml]   [2009]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:x86/cleanups] x86: use kernel_stack_pointer() in kprobes.c
tip-bot for H. Peter Anvin wrote:
> Commit-ID: 98272ed0d2e6509fe7dc571e77956c99bf653bb6
> Gitweb: http://git.kernel.org/tip/98272ed0d2e6509fe7dc571e77956c99bf653bb6
> Author: H. Peter Anvin<hpa@zytor.com>
> AuthorDate: Mon, 12 Oct 2009 14:14:10 -0700
> Committer: H. Peter Anvin<hpa@zytor.com>
> CommitDate: Mon, 12 Oct 2009 14:19:35 -0700
>
> x86: use kernel_stack_pointer() in kprobes.c
>
> The way to obtain a kernel-mode stack pointer from a struct pt_regs in
> 32-bit mode is "subtle": the stack doesn't actually contain the stack
> pointer, but rather the location where it would have been marks the
> actual previous stack frame. For clarity, use kernel_stack_pointer()
> instead of coding this weirdness explicitly.
>
> Signed-off-by: H. Peter Anvin<hpa@zytor.com>
> Cc: Ananth N Mavinakayanahalli<ananth@in.ibm.com>
> Cc: Anil S Keshavamurthy<anil.s.keshavamurthy@intel.com>
> Cc: "David S. Miller"<davem@davemloft.net>
> Cc: Masami Hiramatsu<mhiramat@redhat.com>

Acked-by: Masami Hiramatsu <mhiramat@redhat.com>

Thank you for fixing it!


--
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com



\
 
 \ /
  Last update: 2009-10-13 00:15    [W:0.020 / U:1.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site