lkml.org 
[lkml]   [2009]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86 UV: Fixes for UV rtc timers

* Dimitri Sivanich <sivanich@sgi.com> wrote:

> On Mon, Oct 12, 2009 at 06:23:17PM +0200, Ingo Molnar wrote:
> > hm, why is the (unnecessary seeming) pushing of the
> > ack/exit_idle()/irq_enter()/irq_exit() sequence into the
> > generic_interrupt_extension() function a cleanup?
>
> It seems to make more sense to allow the users of generic_interrupt to
> provide their own sequence, rather than being forced into this one.

An IRQ handler is an irq handler. We should make it _more_ generic, not
less generic.

Also, the generic_interrupt_extension() name sucks a bit. Something like
x86_platform_ipi_callback() would be better.

> > Also, the commit log is rather terse - what is being fixed and why isnt
> > it separate from any cleanups?
>
> I have added to the commit log. See below.

Please separate out the fix and do the cleanups on top of that.

Thanks,

Ingo


\
 
 \ /
  Last update: 2009-10-12 20:11    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site