Messages in this thread | | | Date | Mon, 12 Oct 2009 11:17:29 -0600 | From | Alex Chiang <> | Subject | Re: [PATCH 4/6] ACPI: dock: add struct dock_station * directly to platform device data |
| |
Hi Len,
* Shaohua Li <shaohua.li@intel.com>: > > This patch isn't good. platform_device_add_data will malloc a new > 'struct dock_station' and copy old to it, and later the two copy aren't > consistent. So NACK this one.
If you can drop this patch without requiring a respin from me, go ahead.
If you can't, go ahead and drop what you need, and I'll respin.
I'm going to chew on this a bit and see if I can still salvage it.
> ACK other 5 patches.
Thanks, Shaohua.
/ac
| |