lkml.org 
[lkml]   [2009]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/6] ACPI: dock: add struct dock_station * directly to platform device data
    Hi Len,

    * Shaohua Li <shaohua.li@intel.com>:
    >
    > This patch isn't good. platform_device_add_data will malloc a new
    > 'struct dock_station' and copy old to it, and later the two copy aren't
    > consistent. So NACK this one.

    If you can drop this patch without requiring a respin from me, go
    ahead.

    If you can't, go ahead and drop what you need, and I'll respin.

    I'm going to chew on this a bit and see if I can still salvage
    it.

    > ACK other 5 patches.

    Thanks, Shaohua.

    /ac



    \
     
     \ /
      Last update: 2009-10-12 19:25    [W:3.029 / U:0.396 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site