Messages in this thread | | | Date | Mon, 12 Oct 2009 12:05:03 -0400 | From | Mathieu Desnoyers <> | Subject | Re: [this_cpu_xx V5 19/19] SLUB: Experimental new fastpath w/o interrupt disable |
| |
* Christoph Lameter (cl@linux-foundation.org) wrote: > On Mon, 12 Oct 2009, Mathieu Desnoyers wrote: > > > local_irq_enable(); > > preempt_enable(); <- barrier() > > > > In the first scenario, the compiler barrier is at the beginning of the > > slow path function, which should impose less restrictions on the compiler > > optimizations. > > Again: The next statement is a call to a function that calls the page > allocator. Its one call vs two for me. Plus the flow of things is much > cleaner and less obfuscated. >
That's a convincing argument, I agree.
Thanks,
Mathieu
-- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
| |