[lkml]   [2009]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 3/4] Run pci_apply_final_quirks() sooner.
    Having this as a device_initcall() means that some real device drivers
    can actually initialise _before_ the quirks are run, which is wrong.

    We want it to run _before_ device_initcall(), but _after_ fs_initcall(),
    since some arch-specific PCI initialisation like pcibios_assign_resources()
    is done at fs_initcall().

    We could use rootfs_initcall() but I actually want to use that for the
    IOMMU initialisation, which has to come after the quirks, but still
    before the real devices. So use fs_initcall_sync() instead -- since this
    is entirely synchronous, it doesn't hurt that it'll escape the

    Signed-off-by: David Woodhouse <>
    drivers/pci/quirks.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
    index 77bf620..4e1b1b8 100644
    --- a/drivers/pci/quirks.c
    +++ b/drivers/pci/quirks.c
    @@ -2584,7 +2584,7 @@ static int __init pci_apply_final_quirks(void)
    return 0;

    void pci_fixup_device(enum pci_fixup_pass pass, struct pci_dev *dev) {}

     \ /
      Last update: 2009-10-12 14:15    [W:0.031 / U:18.132 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site