Messages in this thread | | | Date | Mon, 12 Oct 2009 12:12:47 +0200 | Subject | Re: [PATCH tracing/kprobes v3 4/7] tracing/kprobes: Avoid field name confliction | From | Frédéric Weisbecker <> |
| |
Le 12 octobre 2009 12:10, Frédéric Weisbecker <fweisbec@gmail.com> a écrit : > 2009/10/8 Masami Hiramatsu <mhiramat@redhat.com>: >> Check whether the argument name is conflict with other field names. >> >> Changes in v3: >> - Check strcmp() == 0 instead of !strcmp(). >> >> Changes in v2: >> - Add common_lock_depth to reserved name list. >> >> Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com> >> Cc: Frederic Weisbecker <fweisbec@gmail.com> >> Cc: Ingo Molnar <mingo@elte.hu> >> Cc: Thomas Gleixner <tglx@linutronix.de> >> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> >> Cc: Steven Rostedt <rostedt@goodmis.org> >> Cc: Mike Galbraith <efault@gmx.de> >> Cc: Paul Mackerras <paulus@samba.org> >> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> >> Cc: Christoph Hellwig <hch@infradead.org> >> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> >> Cc: Jim Keniston <jkenisto@us.ibm.com> >> Cc: Frank Ch. Eigler <fche@redhat.com> >> --- >> >> kernel/trace/trace_kprobe.c | 65 +++++++++++++++++++++++++++++++++++-------- >> 1 files changed, 53 insertions(+), 12 deletions(-) >> >> diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c >> index 030f28c..e3b824a 100644 >> --- a/kernel/trace/trace_kprobe.c >> +++ b/kernel/trace/trace_kprobe.c >> @@ -38,6 +38,25 @@ >> #define MAX_EVENT_NAME_LEN 64 >> #define KPROBE_EVENT_SYSTEM "kprobes" >> >> +/* Reserved field names */ >> +#define FIELD_STRING_IP "ip" >> +#define FIELD_STRING_NARGS "nargs" >> +#define FIELD_STRING_RETIP "ret_ip" >> +#define FIELD_STRING_FUNC "func" > > > If it might conflict, then we should minimize the possibilities for > that to happen. > > What if we prefix these fields with kprobed_ ? > > kprobed_ip > kprobed_nargs > kprobed_ret_ip > kprobed_func > > We are lucky there in that kprobe functions in the kernel can't be kprobed > so it's safe wrt the conflict in the same namespace. > > And we can further schrink the kprobed prefixes in userspace post processing. > > (If you agree with the above, that can be done incrementally). > > Thanks.
I'm an idiot. I should have looked at the 5/7 patch before sending this reply. Just forget about what I said :-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |