Messages in this thread | | | Date | Mon, 12 Oct 2009 12:33:33 +0200 | From | Ingo Molnar <> | Subject | Re: [RESEND PATCH] mce, edac: use an atomic notifier for MCEs decoding |
| |
* Borislav Petkov <borislav.petkov@amd.com> wrote:
> @@ -1420,6 +1428,10 @@ void __cpuinit mcheck_init(struct cpuinfo_x86 *c) > mce_cpu_features(c); > mce_init_timer(); > INIT_WORK(&__get_cpu_var(mce_work), mce_process_work); > + > + if (raw_smp_processor_id() == 0) > + atomic_notifier_chain_register(&x86_mce_decoder_chain, > + &mce_dec_nb); > }
this bit should be done in a cleaner way, by introducing a boot init function for MCE functionality.
(It's also broken if we boot on non-0 CPUs. Doesnt happen currently but still.)
Also, the function names there are pretty messy - please do another, rename patch that does something like:
mcheck_init() => mcheck_cpu_init() mce_init() => __mcheck_cpu_init_generict() mce_cpu_features() => __mcheck_cpu_init_vendor() mce_init_timer() => __mcheck_cpu_init_timer()
etc.
I've applied your patch to x86/mce - please send delta patches to clean up the other aspects of it.
Thanks,
Ingo
| |