Messages in this thread | | | Date | Mon, 12 Oct 2009 12:11:51 +0200 (CEST) | From | John Kacur <> | Subject | Re: [PATCH RFC] frontend.c: Remove the BKL from agp_open |
| |
On Mon, 12 Oct 2009, Dave Airlie wrote:
> On Mon, Oct 12, 2009 at 6:24 AM, John Kacur <jkacur@redhat.com> wrote: > > > > @David Airlie. I was looking at the agp driver for removal of the bkl > > lock. From what I could tell, the mutex_lock(&(agp_fe.agp_mutex)) should > > cover what we need. However, I may have easily missed something, and would > > appreciate your review / comments on the patch. > > This seems fine, though I suck at locking logic, > > One thing to note is the number of users of this interface is probably > close to 0, > so even if this does break something we probably won't ever find out. > > Dave. >
Hmnn, you are listed as the maintainer - don't at least YOU use this driver? Also, if it seem fine to you, can I have an ack?
Thanks
| |