Messages in this thread |  | | | Date | Sun, 11 Oct 2009 16:54:08 +0100 | | From | Alan Cox <> | | Subject | Re: [PATCH RFC] [PATCH] drivers/scsi/ch.c: Remove BKL in ch_open |
| |
> > I'm not so sure. In fact there are some quite umm interesting > > questions about this code, and some of them are shared with other > > modules too. > > > > Consider the following sequence > > > > CPU1 CPU2 > > register_chrdev > > ok > > open device > > takes lock > > > but open does not take the BKL, so the BKL is not protecting you at > all against this..
But module load/unload does - so while the change doesn't appear to cause any problems there is an underlying problem here that wants looking at.
|  |