lkml.org 
[lkml]   [2009]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC] [PATCH] drivers/scsi/ch.c: Remove BKL in ch_open
> > I'm not so sure. In fact there are some quite umm interesting
> > questions about this code, and some of them are shared with other
> > modules too.
> >
> > Consider the following sequence
> >
> > CPU1 CPU2
> > register_chrdev
> > ok
> > open device
> > takes lock
>
>
> but open does not take the BKL, so the BKL is not protecting you at
> all against this..

But module load/unload does - so while the change doesn't appear to cause
any problems there is an underlying problem here that wants looking at.


\
 
 \ /
  Last update: 2009-10-11 17:59    [from the cache]
©2003-2011 Jasper Spaans