lkml.org 
[lkml]   [2009]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: USB serial regression 2.6.31.1 -> 2.6.31.2
From
Date
On Sat, 2009-10-10 at 17:21 -0700, Ben Efros wrote:
>
> Ben Herrenschmidt's patch[1] to retry without SANE_SENSE might be
> combined be able to be used to detect this 'INSANE_SENSE' scenario,
> but not in its current form.
>
> Devices lying about the "additional sense length" doesn't seem all
> that common, so it might be better to just flag the device as insane
> and not worry about reworking Ben Herrenschmidt's patch.

I don't like flagging devices ... though we already somewhat do it for
the mode switch so it would be possible to stick the flag there.

Another option is to set the insane flag from a retry path similar
to what I posted so that it doesn't ping pong.

In any case, a decision should be made soon as current -stable is broken
and these devices are very common.

Cheers,
Ben.



\
 
 \ /
  Last update: 2009-10-11 07:33    [W:0.087 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site