Messages in this thread | | | Date | Sun, 11 Oct 2009 23:08:10 +0200 | From | Frederic Weisbecker <> | Subject | Re: [patch 11/28] nvram: Drop the bkl from nvram_llseek() |
| |
On Sun, Oct 11, 2009 at 09:31:40PM +0200, Arnd Bergmann wrote: > On Saturday 10 October 2009, Thomas Gleixner wrote: > > There is nothing to protect inside nvram_llseek(), the file > > offset doesn't need to be protected and nvram_len is only > > initialized from an __init path. > > > > It's safe to remove the big kernel lock there. > > > > The generic_nvram driver still uses ->ioctl instead of ->unlocked_ioctl. > I guess it would be helpful to change that in the same series, so we > don't get the BKL back as soon as someone does a pushdown into the > remaining ioctl functions. > > Arnd <><
Right! I'll add that in a second patch.
I've completely forgotten this ioctl/unlocked_ioctl thing.
| |