lkml.org 
[lkml]   [2009]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sound_core.c: Remove BKL from soundcore_open
On Sun, 11 Oct 2009 09:20:15 -0600
Jonathan Corbet <corbet@lwn.net> wrote:

> Changing the
> BKL to a mutex is a real semantic change which requires a real survey
> of the code affected.

One other aspect of this I forgot to mention...it's actually possible
(if unlikely) that one of those lower-level open routines depends on
the BKL's release-on-sleep semantics. Swapping in a mutex would change
that behavior, possibly resulting in deadlocks.

I think it was Alan who once pointed out that the BKL is badly
misnamed. It isn't really a lock, it's a modified execution
environment designed to let naive kernel code think it's still running
in a uniprocessor, no-preemption situation. Replacing the BKL with a
different lock changes that environment, so one has to be *really*
careful about looking for any assumptions which may remain in the code.

That's why BKL-hunting is harder than it looks - and why the BKL has
hung around for all these years.

jon


\
 
 \ /
  Last update: 2009-10-11 19:23    [W:3.292 / U:1.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site