lkml.org 
[lkml]   [2009]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 27/28] drivers: Remove BKL from scx200_gpio
    cycle_kernel_lock() was added during the big BKL pushdown. It should
    ensure the serializiation against driver init code. In this case there
    is nothing to serialize. Remove it.

    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Cc: Jim Cromie <jim.cromie@gmail.com>
    ---
    drivers/char/scx200_gpio.c | 2 --
    1 file changed, 2 deletions(-)

    Index: linux-2.6-tip/drivers/char/scx200_gpio.c
    ===================================================================
    --- linux-2.6-tip.orig/drivers/char/scx200_gpio.c
    +++ linux-2.6-tip/drivers/char/scx200_gpio.c
    @@ -12,7 +12,6 @@
    #include <linux/kernel.h>
    #include <linux/init.h>
    #include <linux/platform_device.h>
    -#include <linux/smp_lock.h>
    #include <asm/uaccess.h>
    #include <asm/io.h>

    @@ -52,7 +51,6 @@ static int scx200_gpio_open(struct inode
    unsigned m = iminor(inode);
    file->private_data = &scx200_gpio_ops;

    - cycle_kernel_lock();
    if (m >= MAX_PINS)
    return -EINVAL;
    return nonseekable_open(inode, file);



    \
     
     \ /
      Last update: 2009-10-10 18:15    [W:0.020 / U:32.108 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site