lkml.org 
[lkml]   [2009]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] battery: Fix charge_now returned by broken batteries
From
On Sat, Oct 10, 2009 at 11:25 PM, Pavel Machek <pavel@ucw.cz> wrote:
> Hi!
>
>> >> In "broken" batteries (is it broken finally? or is it expected
>> >> behaviour?) like mine the old problem will be corrected, as it was
>> >> only present in the charged state.
>> >
>> > I believe you better work around this in userspace... or agree that
>> >>100% charge is possible.
>>
>> I agree that >100% charge is possible while charging (because that
>> would mean the battery is over the last charged level); however, what
>> does it mean when charged?
>
> Well, maybe the battery only updates full_charge_capacity during
> powerdown or when the moon is full or something? (IOW you may be
> breaking already working machines).
>

I do not know about batteries as I said, I was waiting for someone to
point out how batteries (normally/should) work.

>> In any case, my laptop's battery is not charging over 100% its
>> original capacity anyway, just reporting a wrong value.
>
> True. But I do not think  you are fixing it properly. Maybe ask for
> fixed BIOS?

Well, many BIOS/systems are broken and Linux has to workaround them. I
am sure there are a lot of broken batteries out there.

>
> Or perhaps add quirk based on DMI or something?

My battery is easily identified by its model name, so maybe we can
apply the workaround only to known hardware. Still, that is a "heavy"
solution, as I suppose there are many many battery models in the
world. That is why I was asking whether some kind of standard/unified
batteries' values/behavior exists (or implement it) that we can try to
achieve easily with some heuristics like the one I proposed, instead
of some kind of huge table-based workaround system.

>                                                                        Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-10-10 23:51    [W:0.161 / U:0.360 seconds]
©2003-2014 Jasper Spaans. Advertise on this site