Messages in this thread Patch in this message | | | Date | Sat, 10 Oct 2009 15:37:26 -0000 | From | Thomas Gleixner <> | Subject | [patch 25/28] parisc: Remove BKL from eisa_eeprom |
| |
Remove the empty ioctl and the cycle_kernel_lock() in eisa_eeprom_open() which got there with the big BKL push down. There is nothing to wait for and sychronize with after the misc device has been registered.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Kyle McMartin <kyle@parisc-linux.org> --- drivers/parisc/eisa_eeprom.c | 10 ---------- 1 file changed, 10 deletions(-)
Index: linux-2.6-tip/drivers/parisc/eisa_eeprom.c =================================================================== --- linux-2.6-tip.orig/drivers/parisc/eisa_eeprom.c +++ linux-2.6-tip/drivers/parisc/eisa_eeprom.c @@ -75,17 +75,8 @@ static ssize_t eisa_eeprom_read(struct f return ret; } -static int eisa_eeprom_ioctl(struct inode *inode, struct file *file, - unsigned int cmd, - unsigned long arg) -{ - return -ENOTTY; -} - static int eisa_eeprom_open(struct inode *inode, struct file *file) { - cycle_kernel_lock(); - if (file->f_mode & FMODE_WRITE) return -EINVAL; @@ -104,7 +95,6 @@ static const struct file_operations eisa .owner = THIS_MODULE, .llseek = eisa_eeprom_llseek, .read = eisa_eeprom_read, - .ioctl = eisa_eeprom_ioctl, .open = eisa_eeprom_open, .release = eisa_eeprom_release, };
| |