Messages in this thread | | | Date | Thu, 1 Oct 2009 10:11:02 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] generate-cmdlist.sh should be either executable or run as parameter of "." |
| |
* Sam Ravnborg <sam@ravnborg.org> wrote:
> On Wed, Sep 30, 2009 at 02:08:22PM +0200, Ingo Molnar wrote: > > > > * Mulyadi Santosa <mulyadi.santosa@gmail.com> wrote: > > > > > I believe this is just a small glitch. generate-cmdlist.sh by default > > > should be made as executable. But since one might forgot to do it, we > > > could simply call it as an argument "." or "source" or even "sh -c". I > > > pick "." > > > > > > Tested in 2.6.31 > > > > > > Signed-off-by: Mulyadi Santosa <mulyadi.santosa@gmail.com> > > > > hm, generate-cmdlist.sh is executable in the upstream kernel repo. It > > apparently isnt executable on your box - why? > > Whatever - we should try to avoid relying on executable bit being set. > umask can prevent this is tree is checkout as one user and build as > another user.
Fair enough - i'll queue the patch up.
Ingo
| |