lkml.org 
[lkml]   [2009]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: kernel BUG at drivers/ide/ide-disk.c:187 (2.6.31)
Date
On Thursday 01 October 2009 18:40:34 David Miller wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Date: Thu, 1 Oct 2009 11:25:40 +0200
>
> > The problem is that you simply cannot know what is the system state here.
> >
> > Thus when the unknown block layer request is encountered the best thing
> > you can do is to BUG early instead of allowing the situation when some
> > requests are silently dropped and possibly causing the data corruption.
>
> Yes, but if you BUG() in this kind of location, the chance of getting
> the debugging information from the user can be close to zero. We were
> very lucky this time :-)

Do you mean that there is higher chance of user noticing some WARN_ON
warning somewhere in the log than OOPS? I don't quite believe it..

> If we're tossing a request, signal an error to the submitter.
>
> I hear we have infrastructure for that :-)

It has its own problems (see blk_execute_rq() overriding error values
for one of many examples)..

Anyway this is completely besides the point here (however please don't
let it stop you from fixing the aforementioned infrastructure) until
the whole issue gets debugged properly and I'd be quite happy to do it
under normal circumstances but since:

- you are always jumping the gun with your strong opinions before people
even had chance to debug the issue properly and find real root causes
(vide infamous sparc cmd64x problems, which were caused by the real
bugfixes and were completely fixed within 48h from the initial report)

- for the last three months you haven't debugged/fixed a single IDE issue
and you keep dodging every single bug-report

- I have neither time nor interest for this kind of silly corporate-style
games (I had some really good laugh few times though :)

- I really do not have to work on IDE (never had, it was always a hobby)

- I'm not the maintainer any longer :)

I simply do not even want to be cc:ed on IDE problems unless it is a paid
job or mail comes from the person who in the past proved the ability to
work well with others.

Thank you for understanding.


\
 
 \ /
  Last update: 2009-10-01 20:23    [W:0.954 / U:0.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site