| Date | Thu, 1 Oct 2009 10:12:10 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH 19/19] workqueue: implement concurrency managed workqueue |
| |
On Thu, 1 Oct 2009, Tejun Heo wrote: > > To solve the above issues, this patch implements concurrency-managed > workqueue.
Ok, all the other patches in the series looked great, this one looks scary. Everything else was pretty small and targeted, and if bugs appear, bisection would show the step that was nasty.
And then comes the big flag-day patch that actually introduces all the new logic, and is the most complex of the lot.
Maybe it's inevitable, but if this one could be split up a bit more, I'd find the series less scary.
I don't know how, though (except by adding code that simply isn't used in previous patches, and that doesn't really help anything at all), so maybe the big "switch everything over at once" thing is unavoidable.
Linus
|