Messages in this thread |  | | | Subject | Re: Possible bug in ftrace_profile_enable_event | | From | Steven Rostedt <> | | Date | Thu, 01 Oct 2009 02:20:35 -0400 |
| |
On Thu, 2009-10-01 at 14:50 +1000, Paul Mackerras wrote:
> So we only allocate trace_profile_buf and trace_profile_buf_nmi if > total_profile_count was zero on entry, but if we get an error returned > from event->profile_enable(), we free them both unconditionally, > regardless of the value of total_profile_count. That seems wrong. Is > there a subtle reason why that is the right thing to do? > > (Also, is kfree the appropriate counterpart to alloc_percpu?)
Hi Paul,
I think you have a valid point. Frederic and I are here in Dresden (last day). I'll make sure he sees this.
Thanks,
-- Steve
|  |