lkml.org 
[lkml]   [2009]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -v7][RFC]: mutex: implement adaptive spinning


    On Sat, 10 Jan 2009, Ingo Molnar wrote:
    >
    > - 'static inline' functions in .c files that are not used cause no build
    > warnings - while if we change them to 'static', we get a 'defined but
    > not used' warning. Hundreds of new warnings in the allyesconfig builds.

    Well, duh. Maybe they shouldn't be marked "inline", and maybe they should
    be marked with "__maybe_unused" instead.

    I do not think it makes sense to use "inline" as a way to say "maybe I
    won't use this function".

    Yes, it's true that "static inline" won't warn, but hey, as a way to avoid
    a warning it's a pretty bad one.

    Linus


    \
     
     \ /
      Last update: 2009-01-10 02:43    [W:4.060 / U:0.376 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site