lkml.org 
[lkml]   [2009]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: libata: make parallel port scan a per-host opt-in feature


On Fri, 9 Jan 2009, Linus Torvalds wrote:
>
> On Fri, 9 Jan 2009, Linus Torvalds wrote:
> >
> > On Fri, 9 Jan 2009, Arjan van de Ven wrote:
> > >
> > > + if (!hpriv->cap & HOST_CAP_SSS)
> > > + host->flags |= ATA_HOST_PARALLEL_SCAN;
> > > +
> >
> > I don't think that does what you think it does.
>
> And furthermore I'm surprised gcc doesn't warn about it. It would seem to
> be an obvious thing to warn about. I'll see what a sparse warning would
> look like.

Heh. sparse already warns:

warning: dubious: !x & y

although I'm not sure that's necessarily the most readable warning ever.

Linus


\
 
 \ /
  Last update: 2009-01-10 02:03    [W:0.109 / U:1.032 seconds]
©2003-2014 Jasper Spaans. Advertise on this site