lkml.org 
[lkml]   [2009]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 3/5] Fix dubious bitwise 'and' usage spotted by sparse.
    From
    Date
    It doesn't change the semantics, but it looks like
    the logical 'and' was meant to be used here.
    ---
    drivers/media/video/gspca/m5602/m5602_s5k4aa.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/media/video/gspca/m5602/m5602_s5k4aa.c b/drivers/media/video/gspca/m5602/m5602_s5k4aa.c
    index 14b1eac..c3ebcca 100644
    --- a/drivers/media/video/gspca/m5602/m5602_s5k4aa.c
    +++ b/drivers/media/video/gspca/m5602/m5602_s5k4aa.c
    @@ -114,7 +114,7 @@ int s5k4aa_read_sensor(struct sd *sd, const u8 address,
    if (err < 0)
    goto out;

    - for (i = 0; (i < len) & !err; i++) {
    + for (i = 0; (i < len) && !err; i++) {
    err = m5602_read_bridge(sd, M5602_XB_I2C_DATA, &(i2c_data[i]));

    PDEBUG(D_CONF, "Reading sensor register "


    \
     
     \ /
      Last update: 2009-01-10 00:43    [W:0.045 / U:1.260 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site