Messages in this thread | | | Date | Thu, 8 Jan 2009 14:34:43 -0500 | From | "Mike Frysinger" <> | Subject | Re: [PATCH 2/2] netdev: bfin_mac: enable VLAN support in Blackfin MAC driver |
| |
On Thu, Jan 8, 2009 at 14:30, David Miller wrote: > From: "Mike Frysinger" <vapier >> On Thu, Jan 8, 2009 at 14:01, Mike Frysinger wrote: >> > On Thu, Jan 8, 2009 at 13:55, David Miller wrote: >> >> We can get VLAN packets received and sent, using AF_PACKET >> >> sockets, for example. The chip should still respect those >> >> even if VLAN proper is not being utilized. >> > >> > any tips on doing that ? >> >> or rather, is there a driver or you two you can point out that is >> doing this correctly ? the ones i looked at seemed to be doing it >> like the patch we posted ... > > And I disagree with how those drivers are doing it :-) > > At least the programming of the chip to accept all packet > types properly, VLAN or not, regardless of kernel config, > is definitely IMHO the way to go.
i know on our side we all agree with you, we just didnt (dont) know any better ;) -mike
| |