lkml.org 
[lkml]   [2009]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/4] wimax: fix '#ifndef CONFIG_BUG' layout to avoid warning
    From
    From: Inaky Perez-Gonzalez <inaky@linux.intel.com>
    Date: Wed, 7 Jan 2009 11:22:19 -0800

    > Reported by Randy Dunlap:
    >
    > > Also, this warning needs to be fixed:
    > >
    > > linux-next-20090106/net/wimax/id-table.c:133: warning: ISO C90
    > > forbids mixed declarations and code
    >
    > Move the return on #defined(CONFIG_BUG) below the variable
    > declarations so it doesn't violate ISO C90.
    >
    > On wimax_id_table_release() we want to do a debug check if CONFIG_BUG
    > is enabled. However, we also want the debug code to be always compiled
    > to ensure there is no bitrot. It will be optimized out by the compiler
    > when CONFIG_BUG is disabled.
    >
    > Added a note to the function header stating this.
    >
    > Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>

    Applied.


    \
     
     \ /
      Last update: 2009-01-08 20:09    [W:0.021 / U:31.024 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site