lkml.org 
[lkml]   [2009]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] async: Don't call async_synchronize_full_special() while holding sb_lock
    From
    Date
    sync_filesystems() shouldn't be calling async_synchronize_full_special
    while holding a spinlock. The second while loop in that function is the
    right place for this anyway.

    Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
    Cc: Arjan van de Ven <arjan@linux.intel.com>
    Reported-by: Grissiom <chaos.proton@gmail.com>

    diff --git a/fs/super.c b/fs/super.c
    index cb20744..7d67387 100644
    --- a/fs/super.c
    +++ b/fs/super.c
    @@ -458,7 +458,6 @@ void sync_filesystems(int wait)
    if (sb->s_flags & MS_RDONLY)
    continue;
    sb->s_need_sync_fs = 1;
    - async_synchronize_full_special(&sb->s_async_list);
    }

    restart:
    @@ -471,6 +470,7 @@ restart:
    sb->s_count++;
    spin_unlock(&sb_lock);
    down_read(&sb->s_umount);
    + async_synchronize_full_special(&sb->s_async_list);
    if (sb->s_root && (wait || sb->s_dirt))
    sb->s_op->sync_fs(sb, wait);
    up_read(&sb->s_umount);
    --
    David Kleikamp
    IBM Linux Technology Center



    \
     
     \ /
      Last update: 2009-01-08 16:49    [W:0.020 / U:92.672 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site