lkml.org 
[lkml]   [2009]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ring_buffer: fix ring_buffer_event_length()

* Steven Rostedt <rostedt@goodmis.org> wrote:

>
> On Thu, 8 Jan 2009, Ingo Molnar wrote:
> >
> > That is a pretty useless duplication of the subject line, so i dropped it.
> > When the subject line explains the practical impact already, there's no
> > need to add the impact line.
>
> Actually, Frederic and I had a discussion about a duplicate Impact line.
> Perhaps someone is searching the git log on "Impact:" looking for all
> fixes. Perhaps just a simple:
>
> Impact: fix
>
> would be sufficient?

hm, okay - but it should be somewhat different. The impact line should
really be a 'description of impact/risk'. That overlaps subject lines some
of the time - but often not. So we could do something more specific like:

Impact: change/fix (unused) ring-buffer API to be more useful

(For future commits.)

Ingo


\
 
 \ /
  Last update: 2009-01-08 15:43    [W:0.229 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site