lkml.org 
[lkml]   [2009]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [GIT] HID updates for 2.6.29
On Wed, 7 Jan 2009, Gabriel C wrote:

> After this merge I get the following panic , by just touching my Wireless USB Mouse :
>
> ...
>
> [ 223.999461] BUG: unable to handle kernel NULL pointer dereference at 0000000000000050
> [ 224.000446] IP: [<ffffffff80224e65>] __ticket_spin_lock+0x9/0x1a
> [ 224.000446] PGD 7b4a5067 PUD 7a24b067 PMD 0
> [ 224.000446] Oops: 0002 [#1] PREEMPT SMP
> [ 224.000446] last sysfs file: /sys/devices/pci0000:00/0000:00:19.0/irq
> [ 224.000446] CPU 0
> [ 224.000446] Modules linked in: i915 binfmt_misc acpi_cpufreq freq_table w83627ehf hwmon_vid fuse loop lp ppdev parport_pc parport joydev pcspkr i2c_i801 intel_agp button sg evdev processor
> [ 224.000446] Pid: 0, comm: swapper Not tainted 2.6.28-06127-g238c6d5 #31
> [ 224.000446] RIP: 0010:[<ffffffff80224e65>] [<ffffffff80224e65>] __ticket_spin_lock+0x9/0x1a
> [ 224.000446] RSP: 0018:ffffffff807e3bd0 EFLAGS: 00010002
> [ 224.000446] RAX: 0000000000000100 RBX: 0000000000000082 RCX: 0000000000000000
> [ 224.000446] RDX: 0000000000000000 RSI: 0000000000000082 RDI: 0000000000000050
> [ 224.000446] RBP: ffffffff807e3bd0 R08: ffff88007d254000 R09: ffffffff806db440
> [ 224.000446] R10: ffffffff8023d95c R11: ffff88007e0a3d80 R12: 0000000000000050
> [ 224.000446] R13: ffffffff807e3c70 R14: 0000000000000006 R15: 0000000000000050
> [ 224.000446] FS: 0000000000000000(0000) GS:ffffffff807ec000(0000) knlGS:0000000000000000
> [ 224.000446] CS: 0010 DS: 0018 ES: 0018 CR0: 000000008005003b
> [ 224.000446] CR2: 0000000000000050 CR3: 000000007e1c0000 CR4: 00000000000006e0
> [ 224.000446] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [ 224.000446] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> [ 224.000446] Process swapper (pid: 0, threadinfo ffffffff80772000, task ffffffff806d8340)
> [ 224.000446] Stack:
> [ 224.000446] ffffffff807e3be0 ffffffff80224f2f ffffffff807e3c00 ffffffff805673a7
> [ 224.000446] ffff88007d22c180 0000000000000000 ffffffff807e3c50 ffffffff80496bc0
> [ 224.000446] ffff880001014740 ffff88000101af00 ffff88000101af00 ffff88007d22c180
> [ 224.000446] Call Trace:
> [ 224.000446] <IRQ> <0> [<ffffffff80224f2f>] default_spin_lock_flags+0x9/0xe
> [ 224.000446] [<ffffffff805673a7>] _spin_lock_irqsave+0x37/0x40
> [ 224.000446] [<ffffffff80496bc0>] hiddev_send_event+0x2e/0xe9
> [ 224.000446] [<ffffffff80496ccd>] hiddev_report_event+0x52/0x54
> [ 224.000446] [<ffffffff8023211c>] ? resched_task+0x45/0x81
> [ 224.000446] [<ffffffff8048cd93>] hid_report_raw_event+0xb3/0x3b3
> [ 224.000446] [<ffffffff80235e86>] ? tg_shares_up+0x183/0x1a3
> [ 224.000446] [<ffffffff80235b6b>] ? enqueue_entity+0x1f8/0x200
> [ 224.000446] [<ffffffff8048d15c>] hid_input_report+0xc9/0xdc
> [ 224.000446] [<ffffffff80494939>] hid_irq_in+0x90/0x194
> [ 224.000446] [<ffffffff804535ef>] usb_hcd_giveback_urb+0x58/0x87
> [ 224.000446] [<ffffffff80469f0f>] uhci_giveback_urb+0x108/0x19d
> [ 224.000446] [<ffffffff8046a666>] uhci_scan_schedule+0x5a8/0x86b
> [ 224.000446] [<ffffffff8023327e>] ? __wake_up+0x43/0x50
> [ 224.000446] [<ffffffff8046c5bc>] uhci_irq+0x13f/0x158
> [ 224.000446] [<ffffffff80453168>] usb_hcd_irq+0x42/0x90
> [ 224.000446] [<ffffffff8056789b>] ? _spin_unlock+0x33/0x3e
> [ 224.000446] [<ffffffff80278485>] handle_IRQ_event+0x2e/0x65
> [ 224.000446] [<ffffffff80279994>] handle_fasteoi_irq+0x8b/0xcb
> [ 224.000446] [<ffffffff8020f08c>] do_IRQ+0x70/0xe4
> [ 224.000446] [<ffffffff8020ce93>] ret_from_intr+0x0/0x29
> [ 224.000446] <EOI> <0>Code: 4c 22 80 44 89 c6 4c 89 cf e8 5e fc ff ff eb 0e 0f b7 f2 0f b6 f8 4c 89 ca e8 75 fc ff ff c9 c3 90 90 55 b8 00 01 00 00 48 89 e5 <f0> 66 0f c1 07 38 e0 74 06 f3 90 8a 07 eb f6 c9 c3 55 48 89 e5
> [ 224.000446] RIP [<ffffffff80224e65>] __ticket_spin_lock+0x9/0x1a
> [ 224.000446] RSP <ffffffff807e3bd0>
> [ 224.000446] CR2: 0000000000000050
[ ... ]
> I've reverted this whole merge from Linus tree ( sorry I don't have any
> time right now to bisect ) and the problem gone.

I believe this is caused by forgotten assignment in usb_register_dev()
error handling introduced in 079034073fa (added Oliver to CC).

Gabriel, could you please verify that the patch below fixes the problem
you are seeing? Thanks.



From: Jiri Kosina <jkosina@suse.cz>
Subject: [PATCH] HID: fix hid->hiddev initialization in hiddev_connect()

Commit 079034073fa ("HID: hiddev cleanup -- handle all error conditions
properly") by mistake removed proper initialization of hid->hiddev pointer
in hiddev_connect() in case usb_register_dev() succeeds for the hiddev node.
Put it properly back in place.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
drivers/hid/usbhid/hiddev.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c
index 6a98f9f..1928e8a 100644
--- a/drivers/hid/usbhid/hiddev.c
+++ b/drivers/hid/usbhid/hiddev.c
@@ -885,6 +885,7 @@ int hiddev_connect(struct hid_device *hid, unsigned int force)
} else {
hid->minor = usbhid->intf->minor;
hiddev_table[usbhid->intf->minor - HIDDEV_MINOR_BASE] = hiddev;
+ hid->hiddev = hiddev;
}

return 0;
--
1.5.6


\
 
 \ /
  Last update: 2009-01-07 11:25    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site