lkml.org 
[lkml]   [2009]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RESEND][RFC PATCH v2] waitfd
    On Wed, 7 Jan 2009, Oleg Nesterov wrote:

    > minor nit...
    >
    > Please note that unlike other sys_...fd() syscalls, sys_waitfd()
    > doesn't allow to pass O_CLOEXEC. Looks like we need a separate
    > "flags" argument...

    I said this even during the first post. Not a minor nit unless we want to
    have a sys_waitfd2 soon after.


    > Also, ioctl(FIONBIO) or fcntl(O_NONBLOCK) have no effect on
    > waitfd, not very good.

    Ack.


    > I'd suggest to remove WNOHANG from waitfd_ctx->ops and treat
    > (->f_flags & O_NONBLOCK) as WNOHANG.

    Ack.


    > (can't resist, ->ops is not the best name ;)

    Ack. "flags" looks a pretty nice shot at it.



    - Davide




    \
     
     \ /
      Last update: 2009-01-07 18:55    [W:0.021 / U:0.524 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site