Messages in this thread | | | From | Laurent Pinchart <> | Subject | Re: strncat() misuse (was: Re: dm_attr_{name,uuid}_show buffer overflow? (was: Re: linux-next: Tree for January 5)) | Date | Wed, 7 Jan 2009 15:39:35 +0100 |
| |
Hi Geert,
On Monday 05 January 2009, Geert Uytterhoeven wrote: > > A quick `git grep strncat' shows a few more misusers of strncat() that may > > cause buffer overflows and should be converted to strlcat(): > | drivers/media/video/uvc/uvc_driver.c: > | strncat(format->name, buffer[8] & (1 << 7) ? " 60Hz" : " 50Hz",
Thanks for the report. As both the source length is fixed and the destination buffer length known, I'll just replace strncat with strcat.
Best regards,
Laurent Pinchart
| |