![]() | |||||||||||||
Messages in this thread |
On Tue, Jan 06, 2009 at 06:22:08PM -0500, Christoph Hellwig wrote: > On Tue, Jan 06, 2009 at 03:08:55PM -0800, Andrew Morton wrote: > > > Btw, this code is still not quite right. We really need to call > > > ->setattr instead of vmtruncate here. Complex filesystem need > > > transaction to properly free blocks, and those transactions are in > > > ->setattr not inside vmtruncate where ->truncate doesn't even have > > > a chance to get the handle to the transaction passed. > > > > > > As these patches don't make it worse this is not a NACK, but more of > > > a heads up. > > > > Sure. Maybe add a FIXME comment for now? > > Ok. I was planning to look into this again, and IIRC Dave already did > when he was at SGI, but his proof of concept patches got lost somewhere. Hmmmm - I think I posted the "it works for XFs but nothing else" POC patches to fsdevel when I first found this.... <rummage> http://marc.info/?l=linux-fsdevel&m=120952722315259&w=2 The thread starts here for those that want the whole story: http://marc.info/?l=linux-fsdevel&m=120946361527726&w=2 Cheers, Dave. -- Dave Chinner david@fromorbit.com | ||||||||||||
| Last update: 2009-01-07 03:19 [from the cache] ©2003-2008 | |||||||||||||