lkml.org 
[lkml]   [2009]   [Jan]   [6]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: 2.6.29 -mm merge plans
FromHarvey Harrison <>
DateTue, 06 Jan 2009 15:49:33 -0800
On Tue, 2009-01-06 at 18:31 -0500, Christoph Hellwig wrote:
> Yes, the version you attached looks much better, and correct.
> 
> Just some minor comments:
> 
> > +++ b/fs/hfsplus/export.c
> > @@ -0,0 +1,118 @@
> > +/*
> > + *  linux/fs/hfsplus/export.c
> > + *
> 
> Please don't put filenames in top of file comments.  They don't serve
> any purpose and easily get out of date.
> 
> > +	if ( be16_to_cpu(entry.type) != HFSPLUS_FOLDER_THREAD) {
> 
> no space after the opening brace, please/

One other nit, byteswap the constant so it can be done at compile-time:

	if (entry.type != cpu_to_be16(HFSPLUS_FOLDER_THREAD)) {
Harvey



\
 
 \ /
  Last update: 2009-01-07 00:53    [from the cache]
©2003-2008