lkml.org 
[lkml]   [2009]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 03/23] cris: introduce asm/swab.h
From
Date
On Tue, 2009-01-06 at 13:59 -0800, Linus Torvalds wrote:
>
> On Tue, 6 Jan 2009, Harvey Harrison wrote:
> >
> > cris holds its arch overrides in an arch/ folder, rename these
> > byteorder.h files to swab.h and include them from asm/swab.h
> >
> > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> > ---
> > arch/cris/include/arch-v10/arch/byteorder.h | 28 ---------------------------
> > arch/cris/include/arch-v10/arch/swab.h | 28 +++++++++++++++++++++++++++
> > arch/cris/include/arch-v32/arch/byteorder.h | 22 ---------------------
> > arch/cris/include/arch-v32/arch/swab.h | 22 +++++++++++++++++++++
>
>
> Since you'e a git user, and you're basically renaming files while then
> putting a new name in place, can you please send patches done with both
> the "-M" flag (rename detection) _and_ the "-B" flag (which breaks
> associations of files even if the name stays the same)?
>
> It's rare that this is needed, but it really helps. Now the patches look
> like a big delete/create event, and it's not at all obvious that the code
> is actually the same before and after.

Sure, I sent regular patches as a courtesy to Andrew in case he slurped
it up, but I can resend with -M -B if you're going to take it directly,
should I wait until I see the remaining 4 arches hit your tree, or will
you worry about the timing?

Harvey



\
 
 \ /
  Last update: 2009-01-06 23:07    [W:0.063 / U:0.024 seconds]
©2003-2011 Jasper Spaans. Advertise on this site