lkml.org 
[lkml]   [2009]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] block: export SSD/non-rotational queue flag through sysfs
    On Mon, Jan 05 2009, Kay Sievers wrote:
    > On Mon, Jan 5, 2009 at 19:54, Jens Axboe <jens.axboe@oracle.com> wrote:
    > > On Mon, Jan 05 2009, Bartlomiej Zolnierkiewicz wrote:
    >
    > >> +static struct queue_sysfs_entry queue_nonrot_entry = {
    > >> + .attr = {.name = "nonrot", .mode = S_IRUGO | S_IWUSR },
    > >> + .show = queue_nonrot_show,
    > >> + .store = queue_nonrot_store,
    > >> +};
    > >> +
    > >
    > > Lets please use a better name for export reasons, non-rotational is a
    > > lot better. Nobody will know what nonrot means :-)
    >
    > What's that negation good for? Can't we just have "rotational", like
    > we have "removable" and not "non-removable"? :)

    Non-rotational is the term typically used, since rotational is the norm
    (still). So I think the negation actually makes sense in this case :-)

    --
    Jens Axboe



    \
     
     \ /
      Last update: 2009-01-06 08:39    [W:0.019 / U:0.044 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site