Messages in this thread | | | Date | Tue, 6 Jan 2009 17:40:06 +0100 | From | Sam Ravnborg <> | Subject | Re: [PATCH] 2.6.28-git4 - powerpc - drivers build fails with !CONFIG_VIOPATH |
| |
On Tue, Jan 06, 2009 at 09:27:24PM +0530, Kamalesh Babulal wrote: > * Sam Ravnborg <sam@ravnborg.org> [2009-01-06 11:46:19]: > > > Hi Kamalesh > > > > Looks good, small nit below. > > > > > config VIOPATH > > > bool > > > - depends on VIODASD || VIOCD || VIOTAPE || ISERIES_VETH > > > - default y > > > + default n > > > > As 'n' is default anyway this line is not needed and I suggest you > > spin a final version of the patch with this removed. > > > > Sam > > Hi Sam, > > Thanks for the review comments. I am resending the patch with the changes > you have recommended. > > Impact: Fix the VIOPATH dependency in the iSeries dependent drivers. > > iSeries depend drivers build fails, when CONFIG_VIOPATH is disabled. > Removing the dependency of VIOPATH by selecting it, when the drivers > dependent on iSeries code. > > Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
| |