Messages in this thread | | | From | Nick Piggin <> | Subject | Re: atomics: document that linux expects certain atomic behaviour from unsigned long | Date | Mon, 5 Jan 2009 21:54:45 +1100 |
| |
On Sunday 04 January 2009 10:14:19 Alan Cox wrote: > > Is there concrete architecture where it breaks? I'd expect i386/x86-64 > > to be safe, and pretty much everyone to be safe as long as that long > > is aligned.... or that was the result of arch-maintainers > > discussion... > > It'll break on x86 if gcc decides to cache the value and you don't have > explicit barriers.
Same as atomic_read on x86.
> If the long is not aligned it's not safe on x86 at all.
Same as atomic_t.
AFAIK, Linux requires aligned loads and stores to int and long (and pointer) to be atomic.
Pretty much everywhere that uses RCU for example does so using atomic pointer loads and stores. The nastiest issue IMO actually is reloading the value through the pointer even if it isn't explicitly dereferenced. RCU gets this right with ACCESS_ONCE. Probably a lot of code using basic types does not. x86 atomic_read maybe should be using ACCESS_ONCE too...
| |