lkml.org 
[lkml]   [2009]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: [PATCH -tip] x86: setup.c fix style problems
    From
    Date
    On Sun, 2009-01-04 at 21:34 +0100, Ingo Molnar wrote:
    > yeah - i mentioned it to you before that there are such cases.
    >

    OK, so here is new patch excluding smp.h:

    [PATCH] x86: setup.c fix style problems

    Impact: cleanup

    Fix:

    WARNING: Use #include <linux/percpu.h> instead of <asm/percpu.h>
    WARNING: Use #include <linux/topology.h> instead of <asm/topology.h>
    WARNING: externs should be avoided in .c files
    ERROR: code indent should use tabs where possible

    total: 2 errors, 3 warnings

    Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
    ---
    arch/x86/kernel/setup.c | 9 +++------
    1 files changed, 3 insertions(+), 6 deletions(-)

    diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
    index ae0d804..57e76ca 100644
    --- a/arch/x86/kernel/setup.c
    +++ b/arch/x86/kernel/setup.c
    @@ -66,6 +66,7 @@

    #include <linux/percpu.h>
    #include <linux/crash_dump.h>
    +#include <linux/topology.h>

    #include <video/edid.h>

    @@ -101,8 +102,6 @@
    #include <asm/paravirt.h>
    #include <asm/hypervisor.h>

    -#include <asm/percpu.h>
    -#include <asm/topology.h>
    #include <asm/apicdef.h>
    #ifdef CONFIG_X86_64
    #include <asm/numa_64.h>
    @@ -216,8 +215,6 @@ EXPORT_SYMBOL(screen_info);
    struct edid_info edid_info;
    EXPORT_SYMBOL_GPL(edid_info);

    -extern int root_mountflags;
    -
    unsigned long saved_video_mode;

    #define RAMDISK_IMAGE_START_MASK 0x07FF
    @@ -823,8 +820,8 @@ void __init setup_arch(char **cmdline_p)
    #else
    num_physpages = max_pfn;

    - if (cpu_has_x2apic)
    - check_x2apic();
    + if (cpu_has_x2apic)
    + check_x2apic();

    /* How many end-of-memory variables you have, grandma! */
    /* need this before calling reserve_initrd */
    --
    1.5.6.6





    \
     
     \ /
      Last update: 2009-01-05 06:09    [W:5.082 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site