Messages in this thread | | | From | Tollef Fog Heen <> | Subject | Re: [PATCH] Winchiphead 340/1: full baud rate and status/control line support | Date | Sun, 04 Jan 2009 11:19:21 +0100 |
| |
]] Alan Cox
| Some niggles but this is a big improvement to the code.
Thanks. New patch incoming RSN.
| > static int ch341_set_baudrate(struct usb_device *dev, | > + struct tty_struct *tty, | > struct ch341_private *priv) | > + baud = CH341_BAUDBASE_FACTOR / t1; | > + | > + if (baud && tty) | > + tty_encode_baud_rate(tty, baud, baud); | | Can you really get a speed below 1 baud ?
Unsure what you mean here? Why would you ever end up with baudrates below 1?
| > + control = priv->line_control; | > + spin_unlock_irqrestore(&priv->lock, flags); | > + | > + return ch341_set_handshake(port->serial->dev, control); | > +} | | This could race another set_handshake ? I'm not sure it matters and I'd | suggest that stuff gets fixed after this is submitted separately
What's the easiest way to fix this?
-- Tollef Fog Heen UNIX is user friendly, it's just picky about who its friends are
| |