Messages in this thread | | | From | Rob Landley <> | Subject | Re: [PATCH 1/3]: Replace kernel/timeconst.pl with kernel/timeconst.sh | Date | Sun, 4 Jan 2009 18:59:56 -0600 |
| |
On Sunday 04 January 2009 14:39:36 H. Peter Anvin wrote: > Rob Landley wrote: > > C) The only calculation which can overflow 64 bits (the ADJ32 one) turns > > out not to need arbitrary precision math, just 72 bits, and if it ever > > uses more than 32 then bottom 32 are all zero before the divide so you > > can do it in three lines. > > ... for the current code (32 bits). When we get an overflow-less 64-bit > implementation, this code will have to be redone, which is not true for > a properly done implementation.
One extra mask and add is a strange definition of "redone", but I can add it now if you like. (I'd personally prefer to wait for something to actually need it, but...)
> -hpa
Rob
| |