Messages in this thread | | | Date | Sun, 4 Jan 2009 23:27:31 +0530 | From | "Jaswinder Singh Rajput" <> | Subject | Re: [PATCH -tip] x86: setup.c fix style problems |
| |
On Sun, Jan 4, 2009 at 10:51 PM, Ingo Molnar <mingo@elte.hu> wrote: > > * Jaswinder Singh Rajput <jaswinder@infradead.org> wrote: > >> Impact: cleanup, fix style problems, more readable >> >> Fixes style problems: >> WARNING: Use #include <linux/smp.h> instead of <asm/smp.h> >> WARNING: Use #include <linux/percpu.h> instead of <asm/percpu.h> >> WARNING: Use #include <linux/topology.h> instead of <asm/topology.h> >> WARNING: externs should be avoided in .c files >> ERROR: code indent should use tabs where possible >> >> total: 2 errors, 4 warnings > > doesnt build on some configs: > > arch/x86/kernel/setup.c:943: error: implicit declaration of function 'prefill_possible_map' >
This problem will only arise if CONFIG_SMP is not defined. Then linux/smp.h will not include asm/smp.h
But why we are keeping non SMP stuff in asm/smp.h, we need to fix this.
JSR
| |