Messages in this thread | | | Date | Sun, 4 Jan 2009 18:23:19 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86: mpparse.c fix style problems |
| |
* Jaswinder Singh Rajput <jaswinderlinux@gmail.com> wrote:
> Hello Ingo, > > On Fri, Jan 2, 2009 at 10:51 PM, Ingo Molnar <mingo@elte.hu> wrote: > > > > i think it would be cleaner to rename all the the mpc->mpc_X fields to > > mpc->X - that alone would give 4 characters per usage site. (we already > > know that it's an 'mpc' entity - no need to duplicate that in the field > > too) > > > > I send [PATCH -tip 0/7] x86 rename all fields mpc_X to X based on this. > > Currently I rename fields of few mpc_X structures from > arch/x86/include/asm/mpspec_def.h. In this file struct > intel_mp_floating is still remaining with mpf_X fields, Is this also > need to be fixed ? if yes then mpf_intel name is OK ? > > Similarly in arch/x86/include/asm/io_apic.h : > 1. struct mp_config_ioapic with mp_X fields (what name will be best ?) > 2. struct mp_config_intsrc with mp_X fields > > These are also used in arch/x86/kernel/mpparse.c > > Please let me know should I fix mp_X things first or should I proceed > further in mpparse.c as per your suggestions.
i think those should be standardized to mpc_X too, and the fields should lose their mp_ prefix.
Ingo
| |