Messages in this thread | | | Date | Fri, 30 Jan 2009 23:44:54 -0500 | From | Kyle McMartin <> | Subject | Re: [PATCH] intel-iommu: intel_iommu_domain_alloc should check 'dmar_disabled' |
| |
On Fri, Jan 16, 2009 at 03:54:12PM -0800, Bhavesh Davda wrote: > > intel_iommu_domain_alloc() will try and iommu_alloc_domain(iommu), > which calls alloc_domain_mem() to allocate out of 'iommu_domain_cache'. > Unfortunately iommu_domain_cache will not be created if booted with > "intel_iommu=off", i.e. dmar_disabled = 1. >
Hi Bhavesh,
What's the callchain that can result in intel_iommu_domain_alloc being called? It looks like most possible callsites are checking intel_iommu_found, which will be 0 since we check dmar_disabled before calling init_dmars to enumerate the iommus.
(I'm looking at 2.6.28.y right now, is there an interim between when you stumbled upon this two weeks ago and git head where it's no longer an issue? I guess it probably got missed due to folks travelling for LCA.)
regards, Kyle
| |