lkml.org 
[lkml]   [2009]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: 2.6.29-rc3: tg3 dead after resume
    Date
    On Saturday 31 January 2009, Ingo Molnar wrote:
    >
    > * Rafael J. Wysocki <rjw@sisk.pl> wrote:
    >
    > > +static struct dev_pm_ops pcie_portdrv_pm_ops = {
    > > + .suspend = pcie_port_device_suspend,
    > > + .resume = pcie_port_device_resume,
    > > + .freeze = pcie_port_device_suspend,
    > > + .thaw = pcie_port_device_resume,
    > > + .poweroff = pcie_port_device_suspend,
    > > + .restore = pcie_port_device_resume,
    > > +};
    >
    > pet peeve: could we please use vertical spaces wherever they improve the
    > code?
    >
    > Something like:
    >
    > static struct dev_pm_ops pcie_portdrv_pm_ops = {
    > .suspend = pcie_port_device_suspend,
    > .resume = pcie_port_device_resume,
    > .freeze = pcie_port_device_suspend,
    > .thaw = pcie_port_device_resume,
    > .poweroff = pcie_port_device_suspend,
    > .restore = pcie_port_device_resume,
    > };
    >
    > ... and it all becomes clear at a glance. Please?

    OK

    Rafael


    \
     
     \ /
      Last update: 2009-01-31 01:51    [W:2.270 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site