Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: 2.6.29-rc3: tg3 dead after resume | Date | Sat, 31 Jan 2009 01:47:02 +0100 |
| |
On Saturday 31 January 2009, Ingo Molnar wrote: > > * Rafael J. Wysocki <rjw@sisk.pl> wrote: > > > +static struct dev_pm_ops pcie_portdrv_pm_ops = { > > + .suspend = pcie_port_device_suspend, > > + .resume = pcie_port_device_resume, > > + .freeze = pcie_port_device_suspend, > > + .thaw = pcie_port_device_resume, > > + .poweroff = pcie_port_device_suspend, > > + .restore = pcie_port_device_resume, > > +}; > > pet peeve: could we please use vertical spaces wherever they improve the > code? > > Something like: > > static struct dev_pm_ops pcie_portdrv_pm_ops = { > .suspend = pcie_port_device_suspend, > .resume = pcie_port_device_resume, > .freeze = pcie_port_device_suspend, > .thaw = pcie_port_device_resume, > .poweroff = pcie_port_device_suspend, > .restore = pcie_port_device_resume, > }; > > ... and it all becomes clear at a glance. Please?
OK
Rafael
| |